OH2-385 | Code improvement: equality check, unused imports, missing dependencies,...

package.json

@@ -3,6 +3,7 @@
   "version": "0.1.0",
   "private": true,
   "dependencies": {
+    "@babel/plugin-proposal-private-property-in-object": "^7.21.11",
     "@date-io/date-fns": "^1.3.13",
     "@emotion/react": "^11.13.0",
     "@emotion/styled": "^11.13.0",

src/components/Private.js

@@ -1,12 +1,11 @@
 import React from "react";
-import { Navigate, Outlet, useLocation } from "react-router-dom";
+import { Navigate, Outlet } from "react-router-dom";
 import { PATHS } from "../consts";
 import { isAuthenticated } from "../libraries/authUtils/isAuthenticated";
 import { useAuthentication } from "../libraries/authUtils/useAuthentication";
 
 export const Private = () => {
   useAuthentication();
-  const { pathname } = useLocation();
 
   return isAuthenticated() ? <Outlet /> : <Navigate to={PATHS.login} replace />;
 };

src/components/accessories/admin/diseases/Diseases.tsx

@@ -37,14 +37,11 @@ export const Diseases = () => {
     });
   };
 
-  const handleViewChange = useCallback(
-    (event: any, value: any) => {
-      if (!isEmpty(value)) {
-        setView(value);
-      }
-    },
-    [view]
-  );
+  const handleViewChange = useCallback((event: any, value: any) => {
+    if (!isEmpty(value)) {
+      setView(value);
+    }
+  }, []);
 
   const predicate = useCallback(
     (disease: DiseaseDTO) => {

src/components/accessories/admin/suppliers/editSupplier/EditSupplier.tsx

@@ -24,7 +24,7 @@ export const EditSupplier = () => {
     if (state?.supId !== Number(id)) {
       navigate(PATHS.admin_suppliers);
     }
-  }, [id, state]);
+  }, [id, navigate, state]);
 
   return (
     <SupplierForm

src/components/accessories/admin/suppliers/supplierForm/SupplierForm.tsx

@@ -30,8 +30,6 @@ import TextField from "../../../textField/TextField";
 import "./styles.scss";
 import { ISupplierFormProps } from "./types";
 
-const FORMAT = /^([0-9]{3})?[0-9]{2,10}$/;
-
 const SupplierForm: FC<ISupplierFormProps> = ({
   fields,
   onSubmit,

src/components/accessories/admin/types/TypesAdmin.tsx

@@ -1,6 +1,6 @@
 import { useAppSelector } from "libraries/hooks/redux";
 import { sortBy } from "lodash";
-import React, { useEffect, useState } from "react";
+import React, { useEffect, useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { Outlet, useLocation, useNavigate } from "react-router";
 import { PATHS } from "../../../../consts";
@@ -16,7 +16,11 @@ const TypesAdmin = () => {
   const { t } = useTranslation();
   const location = useLocation();
   const navigate = useNavigate();
-  const defaultTypeOption: TypeOption = { label: "", value: "" };
+  const defaultTypeOption: TypeOption = useMemo(
+    () => ({ label: "", value: "" }),
+    []
+  );
+
   const [selectedOption, setSelectedOption] =
     useState<TypeOption>(defaultTypeOption);
   const mode = useAppSelector((state) => state.types.config.mode);
@@ -57,7 +61,7 @@ const TypesAdmin = () => {
         setSelectedOption(defaultTypeOption);
       }
     }
-  }, [location]);
+  }, [defaultTypeOption, location, typeOptions]);
 
   const handleTypeChange = (value: string) => {
     if (value?.length > 0) {

src/components/accessories/admission/PatientAdmission.tsx

@@ -83,7 +83,7 @@ const PatientAdmission: FC = () => {
     if (patientCode && creationMode) {
       dispatch(getLastOpd(parseInt(id!!)));
     }
-  }, [dispatch, patientCode, creationMode]);
+  }, [dispatch, patientCode, creationMode, id]);
 
   const fields = useFields(admissionToEdit, lastOpd?.disease);
 
@@ -157,7 +157,7 @@ const PatientAdmission: FC = () => {
       dispatch(getPatient(id!!));
       dispatch(getCurrentAdmission(parseInt(id!!)));
     }
-  }, [createStatus, updateStatus]);
+  }, [createStatus, dispatch, id, updateStatus]);
 
   const resetFormCallback = () => {
     setCreationMode(true);
@@ -173,7 +173,7 @@ const PatientAdmission: FC = () => {
     return () => {
       dispatch(getCurrentAdmissionReset());
     };
-  }, [dispatch]);
+  }, [dispatch, id]);
 
   const onEdit = (row: AdmissionDTO) => {
     setAdmissionToEdit(row);

src/components/accessories/appHeader/AppHeader.tsx

@@ -35,7 +35,7 @@ const AppHeader: FunctionComponent<IOwnProps> = ({ breadcrumbMap }) => {
   );
   useEffect(() => {
     dispatch(getHospital());
-  }, [dispatch, getHospital]);
+  }, [dispatch]);
 
   const hospital = useAppSelector(
     (state) => state.hospital.getHospital.data

src/components/accessories/appHeader/types.ts

@@ -1,5 +1,4 @@
 import { TUserCredentials } from "../../../state/main/types";
-import { TAPIResponseStatus } from "../../../state/types";
 
 export type TBreadcrumbMap = Record<string, string>;
 

src/components/accessories/autocompleteField/AutocompleteField.tsx

@@ -11,7 +11,6 @@ import _ from "lodash";
 import React, {
   ChangeEvent,
   FC,
-  Fragment,
   useCallback,
   useEffect,
   useState,
@@ -76,6 +75,7 @@ const AutocompleteField: FC<IProps> = ({
     }
   };
 
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   const debounceUpdate = useCallback(
     debounce((value: any) => {
       setValue(value);
@@ -111,16 +111,6 @@ const AutocompleteField: FC<IProps> = ({
     return option.label;
   };
 
-  const isSelected = (option: DefaultOptionType, v: DefaultOptionType) => {
-    return option.value === v.value;
-  };
-
-  const rendOption = (props: any, option: DefaultOptionType | string) => {
-    return (
-      <Fragment>{typeof option === "string" ? option : option.label}</Fragment>
-    );
-  };
-
   const filter = createFilterOptions<DefaultOptionType>({
     limit: options_limit,
   });

src/components/accessories/billTable/BillTable.tsx

@@ -91,7 +91,7 @@ export const BillTable: FC<IBillTableProps> = ({ fields }) => {
         dispatch(searchBills(filter));
         break;
     }
-  }, [filter]);
+  }, [dispatch, filter]);
 
   const { setFieldValue, handleBlur } = formik;
 

src/components/accessories/billrecords/BillRecords.tsx

@@ -67,7 +67,7 @@ const BillRecords = () => {
     dispatch(deleteBillReset());
     dispatch(payBillReset());
     dispatch(closeBillReset());
-  }, []);
+  }, [dispatch]);
 
   useEffect(() => {
     if (patient && patient.code) {
@@ -275,7 +275,7 @@ const BillRecords = () => {
         }}
         handleSecondaryButtonClick={() => ({})}
       />
-      <iframe id="ifmcontentstoprint"></iframe>
+      <iframe id="ifmcontentstoprint" title="ifmcontentstoprint"></iframe>
     </div>
   );
 };