Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-385 | Code improvement: equality check, unused imports, missing dependencies,... #668

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

SilverD3
Copy link
Contributor

@SilverD3 SilverD3 commented Oct 3, 2024

See OH2-385.

This PR fixes 242 eslint warnings
eslint-warnings

@mwithi mwithi requested a review from SteveGT96 October 3, 2024 12:56
package.json Show resolved Hide resolved
@SteveGT96
Copy link
Contributor

SteveGT96 commented Oct 8, 2024

OK ! Please fix conflicts and then we could move on.

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit d0dbfc3 into informatici:develop Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants