Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in LED setup after group feedback #261

Closed
wants to merge 1 commit into from
Closed

Conversation

adrivinca
Copy link
Contributor

@adrivinca adrivinca commented Dec 4, 2024

minimal change to the SSP setup upon Volker's suggestion.

I also had to do a last minute change in the data. I missed some csp technologies (having 16 technologies with irregular names does not help automatize the parametrization ..)

I would still like to merge this in main and not just cherry-pick in ssp-dev because I don't want to have divergent branches like in message_data, at least for the water implementation.

anyway, not tests added, no changes in doc, but let me know if I should do a whatsnew

thanks

@khaeru
Copy link
Member

khaeru commented Dec 4, 2024

Incorporated in #235 by cherry-pick.

@khaeru khaeru closed this Dec 4, 2024
@khaeru khaeru added p:SSP-2024 2024 SSP updates and ScenarioMIP water MESSAGEix-Nexus (water) variant labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.6%. Comparing base (c5e275c) to head (888ebb0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #261     +/-   ##
=======================================
- Coverage   77.5%   76.6%   -1.0%     
=======================================
  Files        211     211             
  Lines      16069   16069             
=======================================
- Hits       12469   12321    -148     
- Misses      3600    3748    +148     

see 7 files with indirect coverage changes

@adrivinca
Copy link
Contributor Author

adrivinca commented Dec 4, 2024

I also had to add a last minute change in the data. I missed some csp technologies (having 16 technologies with irregular names does not help automatize the parametrization ..)

I would still like to merge this in main and not just cherry-pick in ssp-dev because I don't want to have divergent branches like in message_data, at least for the water implementation.

but it seems that dew to rebase I need to make a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:SSP-2024 2024 SSP updates and ScenarioMIP water MESSAGEix-Nexus (water) variant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants