Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in SSP parameters and add missing csp data #262

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

adrivinca
Copy link
Contributor

same as #261 but it seems I cannot reopen that Pr because I rebased the branch
here we have:

  1. minimal change to the SSP setup upon Volker's suggestion.
  2. I also had to do a last minute change in the data. I missed some csp technologies (having 16 technologies with irregular names does not help automatize the parametrization ..)

I would still like to merge this in main and not just cherry-pick in ssp-dev because I don't want to have divergent branches like in message_data, at least for the water implementation.

anyway, not tests added, no changes in doc, but let me know if I should do a whatsnew

thanks

@adrivinca adrivinca added the water MESSAGEix-Nexus (water) variant label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.7%. Comparing base (04dad58) to head (d5de791).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #262     +/-   ##
=======================================
- Coverage   77.6%   76.7%   -1.0%     
=======================================
  Files        211     211             
  Lines      16079   16079             
=======================================
- Hits       12481   12333    -148     
- Misses      3598    3746    +148     

see 7 files with indirect coverage changes

@adrivinca adrivinca requested review from glatterf42 and khaeru and removed request for glatterf42 December 5, 2024 07:53
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let let me know if I should do a whatsnew

Did this while reviewing. LGTM! I'll merge once checks pass.

@khaeru khaeru merged commit 44087e4 into main Dec 5, 2024
30 checks passed
@khaeru khaeru deleted the wat_mini_SSPupd branch December 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
water MESSAGEix-Nexus (water) variant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants