Adds scrollingStickyHeader prop and disables bg scaling on Android #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungilation
requested changes
Aug 5, 2017
| }) | ||
| }] | ||
| }}> | ||
| {this.renderStickyHeader()} |
There was a problem hiding this comment.
Fatal redbox error on this.renderStickyHeader() doesn't exist, when prop scrollingStickyHeader is true.
This PR's post comment on scrollingStickyHeader being default to true is also wrong, default is false. Which renders sticky header with new fade behaviour. (awesome improvement at that 🍻)
fungilation
added a commit
to fungilation/react-native-parallax-scroll-view
that referenced
this pull request
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address issue #37 by adding the
scrollingStickyHeaderprop which defaults to true. If disabled, the sticky header will only fade in, making for a smoother transition.Additionally, this disables the background scaling for Android devices since Android listviews cannot scroll beyond their normal range. This prevents the occasional scale "popping" on Android when scrolling down fast.