Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My unofficial fork with cherry picked PRs #78

Open
fungilation opened this issue Aug 5, 2017 · 10 comments
Open

My unofficial fork with cherry picked PRs #78

fungilation opened this issue Aug 5, 2017 · 10 comments

Comments

@fungilation
Copy link
Collaborator

fungilation commented Aug 5, 2017

As this repo is most useful and beautiful, it's a shame PRs aren't being tended. I've just made a PR fixing React.PropTypes warnings since RN 0.45 (#77), and merged 2 other great PRs I want in my own app: #57 and #70.

EDIT: Also merged #81, #109

Use my fork if you find it useful: https://github.com/fungilation/react-native-parallax-scroll-view

@mini-eggs
Copy link

Ah shoot, just went through the trouble of sending a PR for prop types.

@fungilation
Copy link
Collaborator Author

Manually merged #81 from upstream: Changed animation to use native driver (performance!)

@patheinen
Copy link

Perfect - Thanks 👍

@gabrielbull
Copy link

Maybe @i6mi6 can add @fungilation as a collaborator?

@i6mi6
Copy link
Owner

i6mi6 commented Nov 8, 2017

@gabrielbull I added @fungilation as a collaborator. Thanks!

@fungilation
Copy link
Collaborator Author

@i6mi6 thanks. What's the best course of action for merging my fork. Just do it (merging my fork) would be much easier than redo-ing all the associated PRs here. #81 is already merged here so my fork would have to resolve merge conflict if any for same changes that's already merged.

@i6mi6
Copy link
Owner

i6mi6 commented Nov 14, 2017

@fungilation How many PRs are fixed in your fork?

@fungilation
Copy link
Collaborator Author

What I referenced here. All tested working in my own app.

@Li357
Copy link
Contributor

Li357 commented Jun 19, 2018

@i6mi6 @fungilation Any chance of updating the examples in your fork? I can do an update, which can fix #101.

@flikQ

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants