-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal question page #5
Conversation
Django doesn't support this yet :/
Our first end-to-end test
33249b7
to
580c239
Compare
580c239
to
fc25dff
Compare
- add a slug field to the Question so we can look it up in the url - add factoryboy so we can declare database state in tests
c7c7522
to
1e55d05
Compare
Now working with pg in actions |
fcb0f09
to
5d7666b
Compare
5d7666b
to
cff4d39
Compare
@@ -113,4 +114,4 @@ | |||
# Default primary key field type | |||
# https://docs.djangoproject.com/en/5.0/ref/settings/#default-auto-field | |||
|
|||
DEFAULT_AUTO_FIELD = "django.db.models.UUIDField" | |||
DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not UUID?
|
||
# test | ||
createdb consultations_test | ||
createuser consultations_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also be useful to have how to run tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - a couple of trivial questions/comments (which you can address later if you wish).
This pull request:
Most of it is boilerplate and should hopefully be uncontroversial!