Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal question page #5

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Minimal question page #5

merged 10 commits into from
Mar 4, 2024

Conversation

duncanjbrown
Copy link
Contributor

@duncanjbrown duncanjbrown commented Feb 29, 2024

This pull request:

  • creates the first model and the first view/template
  • creates the first end to end test
  • sets up tests in CI including with the database

Most of it is boilerplate and should hopefully be uncontroversial!

@duncanjbrown duncanjbrown force-pushed the feature/question-page branch 6 times, most recently from 33249b7 to 580c239 Compare March 1, 2024 17:40
@duncanjbrown duncanjbrown force-pushed the feature/question-page branch from 580c239 to fc25dff Compare March 1, 2024 17:43
- add a slug field to the Question so we can look it up in the url
- add factoryboy so we can declare database state in tests
@duncanjbrown duncanjbrown force-pushed the feature/question-page branch from c7c7522 to 1e55d05 Compare March 4, 2024 10:16
@duncanjbrown
Copy link
Contributor Author

Now working with pg in actions

@duncanjbrown duncanjbrown changed the title WIP — Feature/question page Minimal question page Mar 4, 2024
@duncanjbrown duncanjbrown force-pushed the feature/question-page branch from fcb0f09 to 5d7666b Compare March 4, 2024 15:46
@duncanjbrown duncanjbrown force-pushed the feature/question-page branch from 5d7666b to cff4d39 Compare March 4, 2024 15:47
@@ -113,4 +114,4 @@
# Default primary key field type
# https://docs.djangoproject.com/en/5.0/ref/settings/#default-auto-field

DEFAULT_AUTO_FIELD = "django.db.models.UUIDField"
DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not UUID?


# test
createdb consultations_test
createuser consultations_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be useful to have how to run tests.

Copy link
Contributor

@nmenezes0 nmenezes0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a couple of trivial questions/comments (which you can address later if you wish).

@nmenezes0 nmenezes0 merged commit 196ce94 into main Mar 4, 2024
1 check passed
@nmenezes0 nmenezes0 deleted the feature/question-page branch March 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants