Use database in Question test

- add a slug field to the Question so we can look it up in the url
- add factoryboy so we can declare database state in tests

consultation_analyser/consultations/migrations/0002_question_slug.py

@@ -0,0 +1,18 @@
+# Generated by Django 5.0.2 on 2024-03-01 17:25
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("consultations", "0001_initial"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="question",
+            name="slug",
+            field=models.CharField(default=None, max_length=256),
+            preserve_default=False,
+        ),
+    ]

consultation_analyser/consultations/models.py

@@ -4,3 +4,4 @@
 
 class Question(models.Model):
     text = models.CharField(max_length=None)  # no idea what's a sensible value for max_length
+    slug = models.CharField(max_length=256)

consultation_analyser/consultations/templates/show_question.html

@@ -1 +1 @@
-How should funding be allocated?
+{{ question.text }}

consultation_analyser/consultations/urls.py

@@ -1,4 +1,4 @@
 from django.urls import path
 from .views import show_question
 
-urlpatterns = [path("questions/how-should-funding-be-allocated", show_question)]
+urlpatterns = [path("questions/<str:slug>", show_question)]

consultation_analyser/consultations/views.py

@@ -1,6 +1,8 @@
 from django.shortcuts import render
 from django.http import HttpRequest
+from .models import Question
 
 
-def show_question(request: HttpRequest):
-    return render(request, "show_question.html")
+def show_question(request: HttpRequest, slug: str):
+    context = {"question": Question.objects.filter(slug=slug).first()}
+    return render(request, "show_question.html", context)

pyproject.toml

@@ -27,6 +27,7 @@ pre-commit = "^3.6.2"
 files = '**/*.py'
 exclude= ['^consultation_analyser/consultations/migrations/']
 
+
 [tool.poetry.group.test.dependencies]
 pytest-django = "^4.8.0"
 

tests/factories.py

@@ -0,0 +1,10 @@
+import factory
+from consultation_analyser.consultations import models
+
+
+class QuestionFactory(factory.django.DjangoModelFactory):
+    class Meta:
+        model = models.Question
+
+    text = "Example question text?"
+    slug = "test-question"

tests/integration/test_question_page.py

@@ -1,3 +1,10 @@
+import pytest
+from tests.factories import QuestionFactory
+
+
+@pytest.mark.django_db
 def test_get_question_page(client):
-    response = client.get("/questions/how-should-funding-be-allocated")
+    question = QuestionFactory(text="How should funding be allocated?", slug="how-should-funding-be-allocated")
+
+    response = client.get(f"/questions/{question.slug}")
     assert "How should funding be allocated?" in str(response.content)