Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(time-duration): getMostSignificantUnitOnlyWithoutApprox created to avoid approx #2586
fix(time-duration): getMostSignificantUnitOnlyWithoutApprox created to avoid approx #2586
Changes from all commits
2ed44b0
ffd255d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 77 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L77
Check warning on line 80 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L79-L80
Check warning on line 84 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L82-L84
Check warning on line 87 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L87
Check warning on line 89 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L89
Check warning on line 91 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L91
Check warning on line 94 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L94
Check warning on line 96 in projects/common/src/time/time-duration.ts
Codecov / codecov/patch
projects/common/src/time/time-duration.ts#L96