Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(time-duration): getMostSignificantUnitOnlyWithoutApprox created to avoid approx #2586

Closed
wants to merge 2 commits into from

Conversation

rahul-p-rajesh
Copy link
Contributor

@rahul-p-rajesh rahul-p-rajesh commented Dec 21, 2023

Description

Currently getMostSignificantUnitOnly in time-duration updates the time value to an approximate value
for e.g on providing 44hr it approximate to 1day

@rahul-p-rajesh rahul-p-rajesh changed the title fix(time-duration): getMostSignificantUnitOnlyWithoutApprox created t… fix(time-duration): getMostSignificantUnitOnlyWithoutApprox created to avoid approx Dec 21, 2023
Copy link

github-actions bot commented Dec 21, 2023

Test Results

       4 files  ±0     316 suites  ±0   32m 32s ⏱️ -1s
1 136 tests ±0  1 136 ✔️ ±0  0 💤 ±0  0 ±0 
1 146 runs  ±0  1 146 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ffd255d. ± Comparison against base commit 389047b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (389047b) 81.69% compared to head (ffd255d) 71.58%.

Files Patch % Lines
projects/common/src/time/time-duration.ts 0.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2586       +/-   ##
===========================================
- Coverage   81.69%   71.58%   -10.12%     
===========================================
  Files         928      928               
  Lines       20790    20804       +14     
  Branches     3136     3141        +5     
===========================================
- Hits        16984    14892     -2092     
- Misses       3665     5659     +1994     
- Partials      141      253      +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahul-p-rajesh rahul-p-rajesh deleted the fix-approx-time-duration branch December 21, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant