Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle (processor_class, None) returned by ModelPatterns #31753

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

molbap
Copy link
Contributor

@molbap molbap commented Jul 2, 2024

transformers-cli add-new-model-like seems currently broken for models like llava where ModelPatterns captures a tuple instead of a processor string descriptor. Adding a special case to handle that.

cc @LysandreJik I suppose?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LysandreJik LysandreJik merged commit c1fe125 into huggingface:main Jul 3, 2024
19 of 21 checks passed
@molbap molbap mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants