add-new-model-like: fix broken script #32460
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
transformers-cli add-new-model-like
seems to be currently broken for creating model similar to any present model.This is the error being presented:There are two commits in this PR:
old_image_processor_class
first element is being chosen when it is an instance of tuple as second element is None. But asViTImageProcessorFast
BaseImageProcessorFast
has been implemented so forvit
model and the models that map their image processor toViTImageProcessor
andViTImageProcessorFast
they have second element asViTImageProcessorFast
instead of None. So, in the questionWill your new model use the same processing class as vit (ViTImageProcessor.....
ViTImageProcessorFast
is not being displayed for creating models similar to those models.This commit fix that.
TypeError: replace() argument 1 must be str, not tuple
) which is breaking the model creation scriptWho can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
@amyeroberts @ArthurZucker @LysandreJik