Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image: keras-nlp<0.14 pin #31687

Closed
wants to merge 32 commits into from
Closed

Conversation

gante
Copy link
Member

@gante gante commented Jun 28, 2024

Temporary PR to update the docker image

@gante
Copy link
Member Author

gante commented Jun 28, 2024

this doesn't look right either 🤔

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker reopened this Jun 28, 2024
@ArthurZucker
Copy link
Collaborator

If the docker images are build correctly, the dev tag should exist

@gante gante changed the title dependencies: keras-nlp<0.14 pin Docker image: keras-nlp<0.14 pin Jun 28, 2024
@gante
Copy link
Member Author

gante commented Jul 1, 2024

pushed image, closing the PR

@gante gante closed this Jul 1, 2024
@amyeroberts
Copy link
Collaborator

@gante it seems something hasn't worked as there's still failures on the CI due keras

@gante gante reopened this Jul 2, 2024
@gante
Copy link
Member Author

gante commented Jul 2, 2024

This does not seem to be triggering the build job, despite having the correct commit message (see here)

Could it be because the branch is from my fork, as opposed to from the repo? Going to test it

@gante
Copy link
Member Author

gante commented Jul 2, 2024

Yup, that was it!

@gante gante closed this Jul 2, 2024
@gante gante deleted the push-ci-image branch July 2, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants