-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: keras-nlp<0.14
pin
#31684
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Fine with pinning to keep things working for now, but would be good to have a plan for future keras updates. @Rocketknight1 could we remove keras-nlp? also cc @ydshieh for reference |
@amyeroberts @ydshieh I followed our docs for version updates, but the resulting PR doesn't look right. What's the expected procedure to update breaking versions? 🤔 I've confirmed that:
However, since the docker images are not updated in this PR, CI will continue to be red |
@gante Tbh, I'm not sure. @ArthurZucker is the best person to ping here, as he wrote the docs |
Let's go on slack @gante ! |
@amyeroberts the If you approve these changes, after the hub failures are resolved:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amyeroberts, we currently don't have a transition plan to move Transformers to Keras 3 because of how disruptive it would be to backwards compatibility. A lot of our TF/Keras usage is users who use it for production workflows with older software versions, so we think it'll be quite a while before we're ready to deprecate all of that and migrate to Keras 3.
For the forseeable future, we're going to keep Transformers on Keras 2, and support Keras 3 by having libraries like KerasNLP and KerasCV pick up the slack and save/load safetensors checkpoints that Transformers can read. This has already started thanks to @ariG23498's work, and more architectures will be supported very soon.
Therefore, it's totally okay to pin Keras and Keras-associated libraries on the last version that supported Keras 2, and that pin will probably be maintained indefinitely.
(btw cc @Wauplin for viz) |
Thanks for the detailed explanation @Rocketknight1 ! |
Thanks for the ping, good to keep in mind. And thanks @Rocketknight1 for the full context! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docker image pushed in #31687 -- merging 🤞 |
What does this PR do?
On the latest
keras-nlp
release -- "KerasNLP no longer supports Keras 2.". This means we don't support this version, as we only support Keras 2