Add WSD scheduler #30231
Merged
Add WSD scheduler #30231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
reviewed
Apr 24, 2024
visheratin
force-pushed
the
wsd-scheduler
branch
2 times, most recently
from
b8e64ec to
e8eadd2
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Looks like it fixed some tests but not all. |
muellerzr
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
LG2M, no idea why that pytorch test is failing 😕
cc @amyeroberts for final review (and ideas(?) was seeing that on another PR of mine iirc)
amyeroberts
approved these changes
Apr 24, 2024
|
@visheratin CI should be green on rebase, we found the issue :) |
visheratin
force-pushed
the
wsd-scheduler
branch
from
e8eadd2 to
ee9f3c3
Compare
|
@muellerzr a couple of tests are still failing. |
|
@visheratin Looks like they were failing because of connection issues with the hub. I've re-run - which should hopefully resolve |
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Added WSD scheduler. * Added tests. * Fixed errors. * Fix formatting. * CI fixes.
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the Warmup-Stable-Decay learning rate scheduler. The scheduler and its benefits are described in detail in the MiniCPM blog post. In short, it allows continuous training and performs better than standard cosine scheduler.
Here is an example of learning rate dynamics with this schedule:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr, @pacman100