Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FA2 when using quantization for remaining models #28341

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

susnato
Copy link
Contributor

@susnato susnato commented Jan 4, 2024

What does this PR do?

Replicates this PR #28203 for remaining models.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@susnato susnato changed the title fix FA2 when using quantization for more models fix FA2 when using quantization for remaining models Jan 4, 2024
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

src/transformers/models/distilbert/modeling_distilbert.py Outdated Show resolved Hide resolved
@susnato
Copy link
Contributor Author

susnato commented Jan 5, 2024

Done! @ArthurZucker

@susnato
Copy link
Contributor Author

susnato commented Jan 5, 2024

CI is green now! @ArthurZucker

@ArthurZucker ArthurZucker merged commit cadf93a into huggingface:main Jan 5, 2024
19 checks passed
@ArthurZucker
Copy link
Collaborator

Thanks for the contribution! FYI @pacman100 and @younesbelkada

staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
)

* fix fa2 autocasting when using quantization

* Update src/transformers/models/distilbert/modeling_distilbert.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/models/distilbert/modeling_distilbert.py

Co-authored-by: Arthur <[email protected]>

---------

Co-authored-by: Arthur <[email protected]>
wgifford pushed a commit to wgifford/transformers that referenced this pull request Jan 21, 2024
)

* fix fa2 autocasting when using quantization

* Update src/transformers/models/distilbert/modeling_distilbert.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/models/distilbert/modeling_distilbert.py

Co-authored-by: Arthur <[email protected]>

---------

Co-authored-by: Arthur <[email protected]>
AjayP13 pushed a commit to AjayP13/transformers that referenced this pull request Jan 22, 2024
)

* fix fa2 autocasting when using quantization

* Update src/transformers/models/distilbert/modeling_distilbert.py

Co-authored-by: Arthur <[email protected]>

* Update src/transformers/models/distilbert/modeling_distilbert.py

Co-authored-by: Arthur <[email protected]>

---------

Co-authored-by: Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants