Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Sort es/toctree.yml like en/toctree.yml #28172

Closed
wants to merge 8 commits into from

Conversation

aaronjimv
Copy link
Contributor

What does this PR do?

I think that the file es/_toctree.yml is not aligned with en/_toctree.yml.

I would like to ask if it was this way intentionally, and if not the case, I would appreciate checking this change.

I kept this part the same because the Performance and Scalability section is not in the Spanish documentation:

- isExpanded: false
    sections:
    - local: debugging
      title: Debugging
    title: Rendimiento y escalabilidad

Thanks for your time.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@osanseviero @stevhliu

@aaronjimv aaronjimv changed the title [docs] Sort es/toctree.yml like en/toctree.ym [docs] Sort es/toctree.yml like en/toctree.yml Dec 20, 2023
@aaronjimv
Copy link
Contributor Author

I was doing a translation of performance.md, whose section is not in the Spanish documentation, and I got the impression that the file es/_toctree.yml is not aligned with en/_toctree.yml. I am open to any comments.

@stevhliu
Copy link
Member

Hi the es/_toctree should be aligned with the English version, so please feel free to realign it! You can also create the Performance and scalability section for the Spanish docs if you'd like 😄

@aaronjimv aaronjimv marked this pull request as ready for review December 21, 2023 16:51
@aaronjimv
Copy link
Contributor Author

Hi @stevhliu, thanks for replying, I add the Performance and Scalability section to es/_toctree.yml and I would like to check this new alignment.

- local: tasks/multiple_choice
title: Selección múltiple
title: Guías de tareas
- section:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be sections otherwise its not recognized :)

Suggested change
- section:
- sections:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@aaronjimv aaronjimv requested a review from stevhliu December 23, 2023 12:17
@aaronjimv aaronjimv closed this Dec 27, 2023
@aaronjimv aaronjimv deleted the Sort_es/_toctree.yml branch December 27, 2023 14:20
@aaronjimv
Copy link
Contributor Author

Continues in #28262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants