-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre_tokenizers
] Fix sentencepiece based Metaspace
#1357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
commented
Oct 7, 2023
ArthurZucker
changed the title
Fix sentencepiece bases Metaspace
Fix sentencepiece based Metaspace
Oct 8, 2023
Serialization is not working properly yet! Will have to fix this |
This was referenced Nov 6, 2023
4 tasks
ArthurZucker
commented
Nov 13, 2023
Narsil
reviewed
Nov 14, 2023
Co-authored-by: Nicolas Patry <[email protected]>
…zers into update-stuff
Narsil
reviewed
Nov 14, 2023
Narsil
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last tiny one.
ArthurZucker
changed the title
Fix sentencepiece based Metaspace
[Nov 14, 2023
pre_tokenizers
] Fix sentencepiece based Metaspace
Co-authored-by: Nicolas Patry <[email protected]>
4 tasks
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue with meta spaces that applies the pre_tokenization to all the sub strings.
with legacy:
without legacy: