N21-1494 Contextual info outdated CTL #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnegns
suggested changes
Nov 24, 2023
apps/server/src/modules/tool/common/service/common-tool.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/domain/tool-configuration-status.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/service/common-tool.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/service/common-tool.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/service/common-tool.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/tool-reference.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/tool-version-service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/domain/tool-configuration-status.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/school-external-tool/controller/api-test/tool-school.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/school-external-tool/service/school-external-tool.service.ts
Outdated
Show resolved
Hide resolved
arnegns
suggested changes
Nov 24, 2023
| isOutdatedOnScopeContext: false, | ||
| isOutdatedOnScopeSchool: false, | ||
| }); | ||
|
|
||
| try { |
There was a problem hiding this comment.
You could try to use a Boolean in the validation functions if it's easy possible
apps/server/src/modules/tool/school-external-tool/controller/api-test/tool-school.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/school-external-tool/service/school-external-tool.service.ts
Outdated
Show resolved
Hide resolved
| isOutdatedOnScopeSchool: true, | ||
| }); | ||
|
|
||
| const latestConfigurationStatus: ToolConfigurationStatus = new ToolConfigurationStatus({ |
There was a problem hiding this comment.
Do you really need two instances ? I could imagine a static function or class which you could use here
apps/server/src/modules/tool/tool-launch/service/tool-launch.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/shared/testing/factory/domainobject/tool/tool-configuration-status.factory.ts
Outdated
Show resolved
Hide resolved
apps/server/src/shared/testing/factory/tool-configuration-status-response.factory.ts
Outdated
Show resolved
Hide resolved
arnegns
approved these changes
Nov 28, 2023
MarvinOehlerkingCap
requested changes
Nov 30, 2023
...er/src/modules/tool/school-external-tool/mapper/school-external-tool-response.mapper.spec.ts
Outdated
Show resolved
Hide resolved
...server/src/modules/tool/school-external-tool/controller/dto/school-external-tool.response.ts
Outdated
Show resolved
Hide resolved
.../src/modules/tool/context-external-tool/controller/dto/tool-configuration-status.response.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/domain/tool-configuration-status.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # apps/server/src/modules/tool/context-external-tool/controller/api-test/tool-reference.api.spec.ts # apps/server/src/modules/tool/context-external-tool/service/tool-reference.service.ts # apps/server/src/modules/tool/context-external-tool/uc/tool-reference.uc.spec.ts # apps/server/src/modules/tool/tool-launch/service/tool-launch.service.ts
# Conflicts: # apps/server/src/modules/tool/common/service/common-tool.service.spec.ts # apps/server/src/modules/tool/common/service/common-tool.service.ts # apps/server/src/shared/testing/factory/index.ts # backup/setup/external-tools.json # backup/setup/school-external-tools.json
MarvinOehlerkingCap
approved these changes
Dec 1, 2023
apps/server/src/modules/tool/school-external-tool/service/school-external-tool.service.spec.ts
Outdated
Show resolved
Hide resolved
...er/src/modules/tool/school-external-tool/mapper/school-external-tool-response.mapper.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/school-external-tool/controller/api-test/tool-school.api.spec.ts
Outdated
Show resolved
Hide resolved
...server/src/modules/tool/context-external-tool/controller/api-test/tool-reference.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/common/mapper/tool-status-response.mapper.ts
Outdated
Show resolved
Hide resolved
3 tasks
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the generation of infos about ctl tools in the tool board element and in courses/rooms. Specific outdated message will be shown for teacher and students.
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1494
hpi-schul-cloud/nuxt-client#2931
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.