N21-1494 Generate Info outdated ctl tools #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinOehlerkingCap
requested changes
Nov 30, 2023
src/components/administration/external-tool-section-utils.composable.ts
Outdated
Show resolved
Hide resolved
src/components/feature-board-external-tool-element/ExternalToolElementAlert.vue
Outdated
Show resolved
Hide resolved
src/components/feature-board-external-tool-element/ExternalToolElementAlert.unit.ts
Outdated
Show resolved
Hide resolved
src/components/feature-board-external-tool-element/ExternalToolElement.vue
Outdated
Show resolved
Hide resolved
src/components/feature-board-external-tool-element/ExternalToolElement.vue
Outdated
Show resolved
Hide resolved
src/components/feature-board-external-tool-element/ExternalToolElement.vue
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/ContextExternalToolApi.composable.unit.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # src/serverApi/v3/api.ts
MarvinOehlerkingCap
requested changes
Dec 1, 2023
src/store/external-tool/school-external-tool-configuration-status.ts
Outdated
Show resolved
Hide resolved
src/components/feature-board-external-tool-element/ExternalToolElementAlert.unit.ts
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/ToolConfigurationStatus.composable.unit.ts
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/ToolConfigurationStatus.composable.ts
Outdated
Show resolved
Hide resolved
src/components/data-external-tool/ToolConfigurationStatus.composable.ts
Outdated
Show resolved
Hide resolved
MarvinOehlerkingCap
previously approved these changes
Dec 4, 2023
| it("should return translationkey for outdated on scope school ", () => { | ||
| const { determineOutdatedTranslationKey, toolConfigurationStatus } = | ||
| setup(); | ||
| toolConfigurationStatus.isOutdatedOnScopeSchool = true; |
There was a problem hiding this comment.
this belongs into the setup (line 60-64)
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
MarvinOehlerkingCap
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This PR handles the generation of infos about ctl tools in the tool board element and in courses/rooms. Specific outdated message will be shown for teacher and students.
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/N21-1494
hpi-schul-cloud/schulcloud-server#4572
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging