Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5642 - internal links in LinkElements on boards #4549

Merged
merged 18 commits into from
Nov 20, 2023

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Nov 10, 2023

Description

The collection of meta tags for internal pages of the project can not be done via scraping. Therefore a set of rules for types of urls and implementations to gather the needed data was implemented.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5642
hpi-schul-cloud/nuxt-client#2907

Changes

Datasecurity


Deployment


New Repos, NPM pakages or vendor scripts


Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@hoeppner-dataport hoeppner-dataport enabled auto-merge (squash) November 20, 2023 12:27
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hoeppner-dataport hoeppner-dataport merged commit 84c267d into main Nov 20, 2023
45 of 46 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-5642-internal-links branch November 20, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants