Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5642 - internal links in LinkElements on boards #2907

Merged
merged 18 commits into from
Nov 21, 2023
Merged

BC-5642 - internal links in LinkElements on boards #2907

merged 18 commits into from
Nov 21, 2023

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Nov 10, 2023 •
edited by UzaeirKhan
Loading

Short Description

The collection of meta tags for internal pages of the project can not be done via scraping. Therefore a set of rules for types of urls and implementations to gather the needed data was implemented.

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5642
hpi-schul-cloud/schulcloud-server#4549

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@hoeppner-dataport hoeppner-dataport mentioned this pull request Nov 10, 2023
Merged
3 tasks
OliverHappe
OliverHappe suggested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@OliverHappe OliverHappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small code quality changes regarding the metadata collection. rest looks super clean. good job! :)

src/components/feature-board-link-element/composables/MetaTagExtractorApi.composable.ts Outdated Show resolved Hide resolved
src/components/feature-board-link-element/composables/MetaTagExtractorApi.composable.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hoeppner-dataport hoeppner-dataport enabled auto-merge (squash) November 21, 2023 10:30
@hoeppner-dataport hoeppner-dataport merged commit b24f8b8 into main Nov 21, 2023
43 of 44 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-5642-internal-links branch November 21, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverHappe OliverHappe OliverHappe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoeppner-dataport @OliverHappe