Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-5522-Implementation of an API for deleting data #4533
BC-5522-Implementation of an API for deleting data #4533
Changes from 99 commits
cce8684
aa32e24
5308f8f
d6e0922
175e495
fd2b9b8
7d3b626
a954f6b
a07bd74
60aa0ac
c65367b
bf27fd8
d477ba7
762a9ee
80430f5
24b823c
f4e10ff
f2f2a5d
9c4be9e
4ab94f8
9a790fd
b5e2a01
495e953
bd430e9
fb3012f
caf07ab
b040876
0d3074e
d935d13
01340fb
c866efe
bf68c68
adb77c9
3f046f5
9a04a4a
9ea749f
46c98b2
539c173
c1f1f35
9ad4206
f422a7b
8c46093
3b58d13
01bdd63
4fc4c70
aba6e1a
6764f95
15ed045
2a15fe3
2e80ece
c57995f
011b0f7
ccf0aef
30ab3f4
6feb0a8
8b6243e
2ffb06a
4bbf149
a6f0b6a
0188096
2e07dc3
3826319
a0046bc
8373501
2695b3d
92dba86
3155b71
2196f1e
c0ae9d7
b0c730b
3a8f8d4
684cd52
7a97f28
9d40aea
87cdfd2
048875d
8ccf2d6
d2fc5dc
2848964
1e0bb2d
994262f
72e7f31
86b176d
e336196
235a83c
e4b133d
0cd52ca
d86d1e5
41fcd0c
a254858
4892112
fe26bb0
fce93f5
bb48803
ee6c312
7c229e2
49f82f5
2c37383
d98d11c
fc41e5f
eea9009
ed55cdb
53905bb
2496a8b
787ab34
c0567ff
1d53580
084e46e
228ab7a
6590fc0
9d98975
02e37c8
df06ed7
b2fa12f
bc3faa1
d589435
9d6e7c8
a13fc2d
760190d
25b15c6
499d22b
fcacb61
7e75f2b
e482fd6
1d41b33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must add an condition to the ansible Task that only if we want it deploy on ref and prod it will be deploy.
Condition name ist WITH_API_ADMIN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must add an condition to the ansible Task that only if we want it deploy on ref and prod it will be deploy.
Condition name ist WITH_API_ADMIN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not tldraw.
Missing also the settings for it at the dof_app_deploy pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What values should I put in dof app deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default values are ok to put in dof app deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a Proposal for it at dof_app_deploy and then we can see.
From where and how offen it is calld what do you thing about restart?
If it only internal and only less calles then maybe one is okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing also the settings for it at the dof_app_deploy pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What values should I put in dof app deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default ones are ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Reference and Produktion the Default ones for Memory are not Okay, we use the request equal limit.
In this case it shoud be 4Gi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamutmk5 I added variables in dof app deploy. Could you please check them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this ticket/PR, but as follow up ticket. We use the TestApiClient for setup authorised request. Please improve this helper and use it for create real requests in each api.spec file that use a x-api-key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So taking into account all the comments regarding TestAPIClient/TestXapiKeyClient and overriding authguards I see two alternative sollution
@CeEv what should we choose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use option 1 but link this PR, or note my different hints about the helper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CeEv we have this ticket https://ticketsystem.dbildungscloud.de/browse/BC-5903