BC-5522-Implementation of an API for deleting data #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bn-pass
reviewed
Nov 10, 2023
apps/server/src/modules/deletion/controller/dto/deletion-request.body.params.ts
Outdated
Show resolved
Hide resolved
bn-pass
suggested changes
Nov 10, 2023
apps/server/src/modules/deletion/controller/dto/deletion-request.body.params.ts
Show resolved
Hide resolved
apps/server/src/modules/deletion/controller/dto/deletion-request-log.response.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/controller/dto/deletion-execution.params.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/uc/builder/deletion-request-log.builder.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/uc/deletion-request.uc.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/controller/deletion-requests.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/controller/deletion-requests.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/controller/deletion-executions.controller.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/deletion/controller/deletion-executions.controller.ts
Outdated
Show resolved
Hide resolved
…-schul-cloud/schulcloud-server into BC-5522-impl-of-deletion-api
CeEv
requested changes
Nov 29, 2023
CeEv
dismissed stale reviews from mamutmk5, SevenWaysDP, and Metauriel
Code is updated.
CeEv
requested changes
Nov 29, 2023
This reverts commit b2fa12f.
This reverts commit d589435.
…-schul-cloud/schulcloud-server into BC-5522-impl-of-deletion-api
mamutmk5
requested changes
Nov 30, 2023
There was a problem hiding this comment.
We must add an condition to the ansible roles for the Delition api.
Name of the condition is WITH_API_ADMIN and to se how to set is lock at this PR
hpi-schul-cloud/dof_app_deploy#716
Comment on lines
164
to
165
| template: admin-api-server-deployment.yml.j2 | ||
|
|
There was a problem hiding this comment.
We must add an condition to the ansible Task that only if we want it deploy on ref and prod it will be deploy.
Condition name ist WITH_API_ADMIN
Suggested change
| template: admin-api-server-deployment.yml.j2 | |
| template: admin-api-server-deployment.yml.j2 | |
| when: WITH_API_ADMIN is defined and WITH_API_ADMIN|boo |
| kubernetes.core.k8s: | ||
| kubeconfig: ~/.kube/config | ||
| namespace: "{{ NAMESPACE }}" | ||
| template: admin-api-server-svc.yml.j2 |
There was a problem hiding this comment.
We must add an condition to the ansible Task that only if we want it deploy on ref and prod it will be deploy.
Condition name ist WITH_API_ADMIN
Suggested change
| template: admin-api-server-svc.yml.j2 | |
| template: admin-api-server-svc.yml.j2 | |
| when: WITH_API_ADMIN is defined and WITH_API_ADMIN|boo |
mamutmk5
approved these changes
Nov 30, 2023
CeEv
approved these changes
Nov 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
bergatco
pushed a commit
that referenced
this pull request
Dec 6, 2023
* endpoints preparation * auth startegy impl * api impl * some changes * some fixes need in KNL module * changes in uc and register entities * Pr fixes and minor changes * rename file * some fixes * add exposing admin API port from the api-svc * add server test module + delete FileEntity from allEntities * change module * admin api server module test impl * add some tests * add some test for API * add some test * x-api-key.strategy tests * x-api-key-strategy-tests impl * remove test for api-setup-helper, remove unused imports * remove test file * add info for the Admin API port * add test for controller * add test for deletionRequestResponse * remove not needed parameter from constructor * add test for deletionRequestLogResponse * add test for executionParams and requestbodyParams * replace hard-coded Admin API server port value with the one taken from the var * change creation of API method location * change default json * fix import in server module * fixes soma issues * fixes after review * add admin api object * default json chnages * Revert "default json chnages" This reverts commit 6764f95. * Revert "add admin api object" This reverts commit aba6e1a. * Revert "fixes after review" This reverts commit 4fc4c70. * Revert "fixes soma issues" This reverts commit 3b58d13. * fixes after review * Revert "small fixes" This reverts commit ccf0aef, reversing changes made to 011b0f7. * Revert "Revert "small fixes"" This reverts commit 30ab3f4. * default ADMIN_API_KEY * fix some imports * small change in x-api-key.strategy * Update apps/server/src/modules/deletion/uc/builder/deletion-log-statistic.builder.spec.ts Co-authored-by: Bartosz Nowicki <[email protected]> * change default.schema.json * new changes to default.schema.json * fix after review * add logger for error in deeltionRequestUC * fix problem with fileentity * fix imports * add logger to test in uc of deletionModule * change module config * hard-coded Admin API server port after the discussion with Paul * fixes bug during deletion uders data from lessons * fix pipeline * fix pipeline #2 * fix pipeline * fix lint * fix modules imports * fix providers in exports in deletion module * split deletion module and deletion-api.module * move setup sessions to server config * try to fix test coverage * Revert "try to fix test coverage" This reverts commit e336196. * Revert "move setup sessions to server config" This reverts commit 86b176d. * remove api key from default.json * changes to server module * use timers in tests * revert last commit * add testXApiKeyClient * deployment impl * add newlines * add test * change character length * fix imports * fix deployment in PR * PR fixes part 1 * fix build and push * fix prettier * default schema changes * small fixes * fix lint * add registration pins module * change sorting of code lines * small fixes after review * add enabled in admiApiServer * add process.exit * test revert enabled (testing purposes) * Revert "test revert enabled (testing purposes)" This reverts commit b2fa12f. * add default for testers * Revert "add default for testers" This reverts commit d589435. * fix with elsson entity * fix lint * changes in main.yml * fix enabled --------- Co-authored-by: WojciechGrancow <[email protected]> Co-authored-by: Bartosz Nowicki <[email protected]> Co-authored-by: WojciechGrancow <[email protected]> Co-authored-by: Cedric Evers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.