N21-1285 User launches a CTL tool from a board card #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add auto context name for board element
arnegns
approved these changes
Nov 1, 2023
apps/server/src/modules/tool/tool-launch/service/launch-strategy/abstract-launch.strategy.ts
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private async getCourseValue(courseId: EntityId): Promise<string> { |
There was a problem hiding this comment.
We should think about introducing an interface e.g. "ExternalToolsNameProvider" which will be implemented by course and columnboard service and returns an independet object.
The interface should also provide a function to return the toolContextType.
This would decouple our strategy from the services.
The getValue function can use the nestjs reflector to get all implementations of the interface
3 tasks
…nto N21-1285-launch-tool-on-board
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1285
hpi-schul-cloud/nuxt-client#2891
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.