Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1285 User launches a CTL tool from a board card #2891

Merged
merged 7 commits into from
Nov 3, 2023
Merged

N21-1285 User launches a CTL tool from a board card #2891

merged 7 commits into from
Nov 3, 2023

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 2, 2023 •
edited by arnegns
Loading

Short Description

  • create composable for launching tools
  • add tool launching to external tool element
  • delete old external tool store

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1285
hpi-schul-cloud/schulcloud-server#4511

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MarvinOehlerkingCap
- create composable for tool launching
e97c4ea 
- add tool launching to external tool element
- delete old external tool store
@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Nov 2, 2023
Merged
3 tasks
arnegns
arnegns previously approved these changes Nov 2, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@arnegns arnegns enabled auto-merge (squash) November 3, 2023 07:16
@arnegns arnegns merged commit 7992b2f into main Nov 3, 2023
42 checks passed
@arnegns arnegns deleted the N21-1285-launch-tool-on-board branch November 3, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns