Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-619 dp review testing part #4494

Merged
merged 29 commits into from
Oct 25, 2023

Conversation

WahlMartin
Copy link
Contributor

@WahlMartin WahlMartin commented Oct 24, 2023

Description

Review comments testing Part

Links to Tickets or other pull requests

Base links
https://ticketsystem.dbildungscloud.de/browse/EW-619

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

mkreuzkam-cap and others added 29 commits September 14, 2023 15:14
@WahlMartin WahlMartin requested a review from Fshmit October 24, 2023 06:16
@Fshmit Fshmit changed the title Ew 619 dp review testing part EW-619 dp review testing part Oct 24, 2023
@WahlMartin WahlMartin merged commit 4e23612 into EW-570-review-comments Oct 25, 2023
45 of 47 checks passed
@WahlMartin WahlMartin deleted the EW-619-DP-review-testing-part branch October 25, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants