EW-619 dp review testing part (#4494)

* Delete auto generated test file. * Use setup method and account factory in account entity to dto mapper test. * Use setup method and factories in account response mapper test. * Use setup method and test structure in account idm to dto mapper tests. * Use setup method and better test structure in account repo integration test. * Use setup and new test structure in account api test (part 1). * Use setup and new test structure in account api test (part 2). * Add missing description for test case. * update function and solve todo * Use setup and new test structure in account db service test * new test structure account idm service integration test * use setup for account idm service integration test * Use setup and new test structure in account.uc.spec.ts. * use setup for account idm service test * Use setup method and new test structure for account.validation.service test. * use setup and new test structure for account service integration test * Use setup method and new test structure in account.service.spec.ts test. * Fix order in account.service.integration.spec.ts * Remove unnecessary tests and resolved todos. * resolve security hotspot issue * resolve security hotspot issue * Edit describe massages * Edit describe massages part 2 --------- Co-authored-by: Maximilian Kreuzkam <[email protected]> Co-authored-by: Alaitwni <[email protected]> Co-authored-by: Fshmit <[email protected]>
hpi-schul-cloud · Oct 25, 2023 · 4e23612 · 4e23612
1 parent 82f065d
commit 4e23612
Show file tree

Hide file tree

Showing 28 changed files with 5,962 additions and 2,758 deletions.
diff --git a/apps/server/src/modules/account/controller/account.controller.spec.ts b/apps/server/src/modules/account/controller/account.controller.spec.ts
diff --git a/apps/server/src/modules/account/controller/account.controller.ts b/apps/server/src/modules/account/controller/account.controller.ts
@@ -1,8 +1,8 @@
 import { Body, Controller, Delete, Get, Param, Patch, Query } from '@nestjs/common';
 import { ApiOperation, ApiResponse, ApiTags } from '@nestjs/swagger';
-import { Authenticate, CurrentUser } from '@src/modules/authentication/decorator/auth.decorator';
 import { EntityNotFoundError, ForbiddenOperationError, ValidationError } from '@shared/common';
 import { ICurrentUser } from '@src/modules/authentication';
+import { Authenticate, CurrentUser } from '@src/modules/authentication/decorator/auth.decorator';
 import { AccountUc } from '../uc/account.uc';
 import {
 	AccountByIdBodyParams,
@@ -33,6 +33,8 @@ export class AccountController {
 		@Query() query: AccountSearchQueryParams
 	): Promise<AccountSearchListResponse> {
 		return this.accountUc.searchAccounts(currentUser, query);
+
+		// TODO: mapping from domain to api dto should be a responsability of the controller (also every other function here)
 	}
 
 	@Get(':id')