Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5450 - BE fix issue with api generator for SubmissionsResponse #4472

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Oct 13, 2023

Description

When implementing the SubmissionsResponse a bug occurred in the api generation. In this PR, a quick fix was done so that the Api definition is correct, you can see the error there.

https://github.com/hpi-schul-cloud/schulcloud-server/pull/4435/files

However, this implementation is not really ok.

This ticket should investigate and apply the correct fix.

Solution seems to be to revert the changes. The api generator now interprets the types/interfaces correctly.

Links to Tickets or other pull requests

BC-5450

Changes

  • revert the changes from BC-4375
  • remove unnecessary API properties from dueDate for submissions

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher enabled auto-merge (squash) October 16, 2023 07:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MartinSchuhmacher MartinSchuhmacher merged commit fdc040a into main Oct 16, 2023
44 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-5450-fix-response branch October 16, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants