BC-5450 - BE fix issue with api generator for SubmissionsResponse (#4472

) * revert changes from api generator fix * remove unnecessary properties
hpi-schul-cloud · Oct 16, 2023 · fdc040a · fdc040a
1 parent e3afbd4
commit fdc040a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/apps/server/src/modules/board/controller/api-test/submission-item-lookup.api.spec.ts b/apps/server/src/modules/board/controller/api-test/submission-item-lookup.api.spec.ts
@@ -15,7 +15,7 @@ import {
 	userFactory,
 } from '@shared/testing';
 import { ServerTestModule } from '@src/modules/server';
-import { SubmissionsResponse } from '../dto/submission-item/submissions.response';
+import { SubmissionsResponse } from '../dto';
 
 const baseRouteName = '/board-submissions';
 describe('submission item lookup (api)', () => {

diff --git a/apps/server/src/modules/board/controller/dto/element/update-element-content.body.params.ts b/apps/server/src/modules/board/controller/dto/element/update-element-content.body.params.ts
@@ -69,8 +69,6 @@ export class SubmissionContainerContentBody {
 	@IsDate()
 	@IsOptional()
 	@ApiPropertyOptional({
-		required: false,
-		nullable: true,
 		description: 'The point in time until when a submission can be handed in.',
 	})
 	dueDate?: Date;

diff --git a/apps/server/src/modules/board/controller/dto/submission-item/index.ts b/apps/server/src/modules/board/controller/dto/submission-item/index.ts
@@ -4,5 +4,5 @@ export * from './submission-item.response';
 export * from './submission-item.url.params';
 // TODO for some reason, api generator messes up the types
 // import it directly, not via this index seems to fix it
-// export * from './submissions.response';
+export * from './submissions.response';
 export * from './update-submission-item.body.params';
diff --git a/apps/server/src/modules/board/controller/mapper/submission-item-response.mapper.ts b/apps/server/src/modules/board/controller/mapper/submission-item-response.mapper.ts
@@ -1,6 +1,5 @@
 import { SubmissionItem, UserBoardRoles } from '@shared/domain';
-import { SubmissionsResponse } from '../dto/submission-item/submissions.response';
-import { SubmissionItemResponse, TimestampsResponse, UserDataResponse } from '../dto';
+import { SubmissionItemResponse, SubmissionsResponse, TimestampsResponse, UserDataResponse } from '../dto';
 
 export class SubmissionItemResponseMapper {
 	private static instance: SubmissionItemResponseMapper;