Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-939-assign-groups-to-course #4464

Merged
merged 20 commits into from
Oct 16, 2023
Merged

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Oct 9, 2023

Description

This PR will handle userId adjustment to course after creation or update of Courses (you need to assign a class or group to course).

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-939
hpi-schul-cloud/schulcloud-client#3326
hpi-schul-cloud/nuxt-client#2854
hpi-schul-cloud/dof_app_deploy#661

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

apps/server/src/apps/server.app.ts Outdated Show resolved Hide resolved
config/default.schema.json Show resolved Hide resolved
test/services/user-group/hooks/classes.test.js Outdated Show resolved Hide resolved
src/services/user-group/hooks/courses.js Show resolved Hide resolved
test/services/courses/hooks/index.test.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mrikallab mrikallab merged commit 2fc165e into main Oct 16, 2023
44 checks passed
@mrikallab mrikallab deleted the N21-939-assign-groups-to-course branch October 16, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants