Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-939 api generation #2854

Merged
merged 11 commits into from
Oct 16, 2023
Merged

N21-939 api generation #2854

merged 11 commits into from
Oct 16, 2023

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Oct 9, 2023 •
edited
Loading

Short Description

a few changes were made to the ClassInfoResponse, therefore the current api has to be generated

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-939
hpi-schul-cloud/schulcloud-server#4464
hpi-schul-cloud/schulcloud-client#3326
hpi-schul-cloud/dof_app_deploy#661

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

This was referenced Oct 11, 2023
Merged
Merged
Merged
MBergCap
MBergCap requested changes Oct 11, 2023
View reviewed changes
src/store/group.unit.ts Outdated Show resolved Hide resolved
src/store/types/class-info.ts Outdated Show resolved Hide resolved
tests/test-utils/factory/classInfoResponseFactory.ts Show resolved Hide resolved
MBergCap
MBergCap previously approved these changes Oct 12, 2023
View reviewed changes
@mrikallab mrikallab enabled auto-merge (squash) October 16, 2023 13:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mrikallab mrikallab merged commit f0978b3 into main Oct 16, 2023
37 of 38 checks passed
@mrikallab mrikallab deleted the N21-939-assign-groups-to-course branch October 16, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBergCap MBergCap MBergCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgorCapCoder @MBergCap @mrikallab