N21-1250 CTL board element #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
arnegns
approved these changes
Sep 21, 2023
| expect(domainObject.constructor.name).toBe(ExternalToolElement.name); | ||
| }); | ||
|
|
||
| it('should throw error if submissionContainerElement is not a leaf', () => { |
There was a problem hiding this comment.
Doesnt looks like the required test structure
There was a problem hiding this comment.
It follows the test structure of the other tests in the file, that were written by N*
apps/server/src/shared/domain/entity/boardnode/rich-text-element-node.entity.spec.ts
Show resolved
Hide resolved
| @@ -1272,6 +1272,11 @@ | |||
| "default": false, | |||
| "description": "Enables the configuration of custom parameters for context external tools" | |||
| }, | |||
| "FEATURE_COLUMN_BOARD_EXTERNAL_TOOLS_ENABLED": { | |||
There was a problem hiding this comment.
Should we check if ctl feature is enabled when we checking if this env is enabled?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1250
hpi-schul-cloud/dof_app_deploy#644
hpi-schul-cloud/nuxt-client#2818
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.