N21-1250 CTL board element #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
arnegns
suggested changes
Sep 21, 2023
| @@ -73,7 +73,9 @@ export default defineComponent({ | |||
| const submissionsEnabled = | |||
| envConfigModule.getEnv.FEATURE_COLUMN_BOARD_SUBMISSIONS_ENABLED; | |||
|
|
|||
| const dialogWidth = submissionsEnabled ? 426 : 320; | |||
| const dialogWidth: ComputedRef<number> = computed(() => | |||
There was a problem hiding this comment.
Something for north* @OliverHappe @uidp
There was a problem hiding this comment.
Hm, what happens, when there are a lot more elementTypeOptions?
There was a problem hiding this comment.
@uidp the number of elementTypeOptions is fixed at the moment or?
arnegns
previously approved these changes
Sep 22, 2023
# Conflicts: # src/components/feature-board-submission-element/SubmissionContentElement.vue # src/serverApi/v3/api.ts
|
Kudos, SonarCloud Quality Gate passed!
|
arnegns
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/N21-1250
hpi-schul-cloud/dof_app_deploy#644
hpi-schul-cloud/schulcloud-server#4419
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging