Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2136 moin schule logout from svs #3535

Merged
merged 15 commits into from
Nov 12, 2024
Merged

N21-2136 moin schule logout from svs #3535

merged 15 commits into from
Nov 12, 2024

Conversation

GordonNicholasCap
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap commented Oct 29, 2024 •
edited by MarvinOehlerkingCap
Loading

Description

  • add button, route for triggering moin.schule logout from svs

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@GordonNicholasCap GordonNicholasCap mentioned this pull request Oct 29, 2024
Merged
3 tasks
@GordonNicholasCap GordonNicholasCap changed the title N21 2136 moin schule logout from svs N21-2136 moin schule logout from svs Nov 4, 2024
@GordonNicholasCap GordonNicholasCap mentioned this pull request Nov 8, 2024
Merged
3 tasks
@GordonNicholasCap GordonNicholasCap mentioned this pull request Nov 8, 2024
Merged
1 task
MarvinOehlerkingCap
MarvinOehlerkingCap approved these changes Nov 8, 2024
View reviewed changes
controllers/login.js Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GordonNicholasCap GordonNicholasCap merged commit fde330d into main Nov 12, 2024
67 checks passed
@GordonNicholasCap GordonNicholasCap deleted the N21-2136-moin-schule-logout-in-svs branch November 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonNicholasCap @MarvinOehlerkingCap