Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2136-moin-schule-logout-in-svs #3444

Merged
merged 17 commits into from
Nov 12, 2024
Merged

N21-2136-moin-schule-logout-in-svs #3444

merged 17 commits into from
Nov 12, 2024

Conversation

GordonNicholasCap
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap commented Nov 8, 2024 •
edited by MarvinOehlerkingCap
Loading

Short Description

  • added external logout button

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@GordonNicholasCap GordonNicholasCap changed the title N21-2166-moin-schule-logout-in-svs N21-2136-moin-schule-logout-in-svs Nov 8, 2024
This was referenced Nov 8, 2024
Merged
Merged
Merged
MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Nov 8, 2024
View reviewed changes
src/modules/data/system/type/System.ts Outdated Show resolved Hide resolved
src/store/auth.ts Show resolved Hide resolved
src/modules/ui/layout/topbar/UserMenu.vue Outdated Show resolved Hide resolved
src/modules/ui/layout/topbar/Topbar.unit.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GordonNicholasCap GordonNicholasCap merged commit 8701a50 into main Nov 12, 2024
69 checks passed
@GordonNicholasCap GordonNicholasCap deleted the N21-2136-moin-schule-logout-in-svs branch November 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonNicholasCap @MarvinOehlerkingCap