Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set tldraw announcement text #3366

Merged
merged 5 commits into from
Dec 18, 2023
Merged

set tldraw announcement text #3366

merged 5 commits into from
Dec 18, 2023

Conversation

wiaderwek
Copy link
Contributor

@wiaderwek wiaderwek commented Dec 13, 2023

Description

QA note:
Change tested on env:
https://brb-bc-5981-tldraw-announcement.cd.dbildungscloud.dev/dashboard#
https://default-bc-5981-tldraw-announcement.cd.dbildungscloud.dev/dashboard
https://nbc-bc-5981-tldraw-announcement.cd.dbildungscloud.dev/dashboard
No issues found. Everything works with the criteria listed on ticket:
https://ticketsystem.dbildungscloud.de/browse/BC-5981

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5981
hpi-schul-cloud/dof_app_deploy#742

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wiaderwek wiaderwek merged commit 744ec9e into main Dec 18, 2023
41 of 42 checks passed
@wiaderwek wiaderwek deleted the BC-5981-tldraw-announcement branch December 18, 2023 10:26
virgilchiriac pushed a commit that referenced this pull request Dec 18, 2023
* set tldraw announcement text

* fix bolding

---------

Co-authored-by: Tomasz Wiaderek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants