enable dashboard announcement #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
blazejpass
approved these changes
Dec 14, 2023
SevenWaysDP
approved these changes
Dec 15, 2023
| @@ -5,6 +5,7 @@ SC_NAV_TITLE: Thüringer Schulcloud | |||
| SC_CONTACT_EMAIL: [email protected] | |||
| GLOBAL_ANNOUNCEMENT_TEXT: '' | |||
| GLOBAL_ANNOUNCEMENT_ROLES: teacher,administrator | |||
| DASHBOARD_ANNOUNCEMENT_ENABLED: "true" | |||
There was a problem hiding this comment.
why explicitly set it to true here?
it is true in the default, and here should only be used to overwrite that setting if needed
same for brb config
virgilchiriac
pushed a commit
that referenced
this pull request
Dec 18, 2023
* enable dashboard announcement * fix configuration --------- Co-authored-by: Tomasz Wiaderek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-5981
hpi-schul-cloud/schulcloud-client#3366
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review