Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1369 fix locales #3329

Merged
merged 3 commits into from
Oct 12, 2023
Merged

N21-1369 fix locales #3329

merged 3 commits into from
Oct 12, 2023

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Oct 10, 2023 •
edited by mrikallab
Loading

Description

see PR name

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1369
hpi-schul-cloud/nuxt-client#2856

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@IgorCapCoder IgorCapCoder mentioned this pull request Oct 10, 2023
Merged
3 tasks
@mrikallab
Copy link
Contributor

mrikallab commented Oct 12, 2023 •
edited
Loading

github action for unit tests failed..

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IgorCapCoder IgorCapCoder merged commit 3f0f5e9 into main Oct 12, 2023
37 of 38 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1369-locales-fix branch October 12, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrikallab mrikallab mrikallab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorCapCoder @mrikallab