Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1369 fix locales #2856

Merged
merged 2 commits into from
Oct 12, 2023
Merged

N21-1369 fix locales #2856

merged 2 commits into from
Oct 12, 2023

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Oct 10, 2023 •
edited
Loading

Short Description

see PR name

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1369
hpi-schul-cloud/schulcloud-client#3329

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@IgorCapCoder IgorCapCoder mentioned this pull request Oct 10, 2023
Merged
3 tasks
@IgorCapCoder IgorCapCoder enabled auto-merge (squash) October 12, 2023 10:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@IgorCapCoder IgorCapCoder merged commit f312195 into main Oct 12, 2023
46 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1369-locales-fix branch October 12, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrikallab mrikallab mrikallab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorCapCoder @mrikallab