Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: case related to updating archived routing and its UI(#181) #195

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Apr 18, 2024

Related Issues

Related Issue #181

Short Description and Why It's Useful

  • As we need to save the unarchived routings on clicking backdrop, thus added support to directly update the routing status state on clicking unarchive button instead of waiting for the user to close the modal, becuase after unarchiving multiple routings if user clicks backdrop the data is not passed to parent component and the routings are not updated.
  • Improved the case to display archived routing card when we have all the routings as archived

For more info check issue: ionic-21979

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

As we need to save the unarchived routings on clicking backdrop, thus added support to directly update the routing status state on clicking unarchive button instead of waiting for the user to close the modal, becuase after unarchiving multiple routings if user clicks backdrop the data is not passed to parent component and the routings are not updated.
Improved the case to display archived routing card when we have all the routings as archived
@ymaheshwari1 ymaheshwari1 merged commit 6893587 into hotwax:main Apr 18, 2024
2 checks passed
@Adameddy26 Adameddy26 mentioned this pull request Apr 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant