Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI for the route page #181

Closed
1 of 3 tasks
ymaheshwari1 opened this issue Apr 12, 2024 · 2 comments
Closed
1 of 3 tasks

Update UI for the route page #181

ymaheshwari1 opened this issue Apr 12, 2024 · 2 comments
Assignees
@Adameddy26
Labels
enhancement New feature or request release-1.2.0 release-1.2.1

Comments

@ymaheshwari1
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@ymaheshwari1 ymaheshwari1 added the enhancement New feature or request label Apr 12, 2024
@github-project-automation github-project-automation bot moved this from 📅 Planned to 📋 Backlog in Digital Experience Platform Apr 12, 2024
@ymaheshwari1 ymaheshwari1 moved this to 📅 Planned in Digital Experience Platform Apr 12, 2024
@ymaheshwari1 ymaheshwari1 self-assigned this Apr 12, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Apr 12, 2024
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 12, 2024
@ymaheshwari1
Improved: UI for the route page as per the figma(hotwax#181)
04e20c2 
Added support to save the status for group on change instead of button click
Changing the schedule will display an alert to save changes
Moved the batches section to right
Added button block to the description card when no description is present
Updated the fab button for saving unchanges to ion-button at the bottom of batches list
@ymaheshwari1 ymaheshwari1 mentioned this issue Apr 12, 2024
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 12, 2024
@ymaheshwari1
Fixed: case to not update the schedule value on UI until user clicks …
a709cd2 
…the save button, if clicking cancel reverting the value for schedule to previous value(hotwax#181)
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 12, 2024
@ymaheshwari1
Improved: static text in files to have internationlization(hotwax#181)
491b03f
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 12, 2024
@ymaheshwari1
Removed: unwanted css styling(hotwax#181)
6f793bb
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Apr 12, 2024
ymaheshwari1 added a commit that referenced this issue Apr 12, 2024
@ymaheshwari1
Merge pull request #182 from ymaheshwari1/#181
e370448 
Improved: UI for the route page as per the figma(#181)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Apr 12, 2024
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 12, 2024
@ymaheshwari1
Implemented: support to edit groupName(hotwax#181)
fda90ec
@ymaheshwari1 ymaheshwari1 mentioned this issue Apr 12, 2024
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 12, 2024
@ymaheshwari1
Improved: condition to revert the name if updation api fails(hotwax#181)
4d43e7b
ymaheshwari1 added a commit that referenced this issue Apr 12, 2024
@ymaheshwari1
Merge pull request #184 from ymaheshwari1/#181
88454ab 
Implemented: support to edit groupName(#181)
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 18, 2024
@ymaheshwari1
Fixed: case related to updating archived routing and its UI(hotwax#181)
1dfd7ba 
As we need to save the unarchived routings on clicking backdrop, thus added support to directly update the routing status state on clicking unarchive button instead of waiting for the user to close the modal, becuase after unarchiving multiple routings if user clicks backdrop the data is not passed to parent component and the routings are not updated.
Improved the case to display archived routing card when we have all the routings as archived
@ymaheshwari1 ymaheshwari1 mentioned this issue Apr 18, 2024
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 18, 2024
@ymaheshwari1
Improved: comment(hotwax#181)
4574da5
ymaheshwari1 added a commit that referenced this issue Apr 18, 2024
@ymaheshwari1
Merge pull request #195 from ymaheshwari1/#181
6893587 
Fixed: case related to updating archived routing and its UI(#181)
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Apr 24, 2024
@Adameddy26 Adameddy26 moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Apr 24, 2024
@Adameddy26
Copy link

Adameddy26 commented Apr 24, 2024 •
edited
Loading

#182 - https://jam.dev/c/93361b3f-191c-4c8c-a449-67a5ab756375
#182 - https://jam.dev/c/8183a673-97c1-4b0e-8c84-ce2a44ccfb0d
#182 - https://jam.dev/c/0e857617-1f89-4683-92d2-90cfb2f1510f
#184 & #195 - https://jam.dev/c/6efbdfd3-efac-473b-90fd-b7defbcc0e8c

All changes of related to updated UI are verified and working fine in release v1.2.0.
Found one issue related to route archive. To replicate this issue - Archive more than one routings. Open the archived routes modal and then unarchive any one routing. Close the modal to observe the issue.(On closing the modal user is not getting the option to open it again resulting in no presence of archived routings.

https://jam.dev/c/a71dd76d-c593-4c85-80de-27b8fde78a9a
Hence, reopening this ticket.

@Adameddy26 Adameddy26 reopened this Apr 24, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📅 Planned in Digital Experience Platform Apr 24, 2024
ymaheshwari1 added a commit to ymaheshwari1/order-routing-rules that referenced this issue Apr 25, 2024
@ymaheshwari1
Fixed: archived routing cards to be dispalyed correctly after unarchi…
ebc02bd 
…ving a rule(hotwax#181)
@ymaheshwari1 ymaheshwari1 mentioned this issue Apr 25, 2024
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Apr 25, 2024
@ymaheshwari1
Merge pull request #205 from ymaheshwari1/#181
c711ef4 
Fixed: archived routing cards to be dispalyed correctly after unarchiving a rule(#181)
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Apr 25, 2024
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Apr 25, 2024
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Apr 25, 2024
@Adameddy26
Copy link

#182 - https://jam.dev/c/93361b3f-191c-4c8c-a449-67a5ab756375 #182 - https://jam.dev/c/8183a673-97c1-4b0e-8c84-ce2a44ccfb0d #182 - https://jam.dev/c/0e857617-1f89-4683-92d2-90cfb2f1510f #184 & #195 - https://jam.dev/c/6efbdfd3-efac-473b-90fd-b7defbcc0e8c

All changes of related to updated UI are verified and working fine in release v1.2.0. Found one issue related to route archive. To replicate this issue - Archive more than one routings. Open the archived routes modal and then unarchive any one routing. Close the modal to observe the issue.(On closing the modal user is not getting the option to open it again resulting in no presence of archived routings.

https://jam.dev/c/a71dd76d-c593-4c85-80de-27b8fde78a9a Hence, reopening this ticket.

Issue verified and working fine in release v1.2.1. Hence, closing this ticket.

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-1.2.0 release-1.2.1
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ymaheshwari1 @Adameddy26