Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved firebase configuration by adding security headers(#735) #736

Merged
merged 1 commit into from
Dec 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,25 @@
"rewrites": [ {
"source": "**",
"destination": "/index.html"
}]
} ],
"headers": [ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same entry in the other two objects as well (prod and uat).
Also please update the formatting and indentation changes to follow this files pattern.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I will change.

"source": "**",
"headers": [ {
"key": "X-Frame-Options",
"value": "SAMEORIGIN"
},
{
"key": "Content-Security-Policy",
"value": "default-src 'self';font-src 'self' data: *;script-src 'self' 'unsafe-inline' 'unsafe-eval' fonts.googleapis.com;img-src 'self' 'unsafe-inline' *.shopify.com javascript: ;style-src 'self' 'unsafe-inline' *; connect-src 'self' *"
},
{
"key": "strict-transport-security",
"value": "max-age=31536000; includeSubDomains"
},{
"key": "Permissions-Policy",
"value": "camera=self"
} ]
}]
},
{
"target": "uat",
Expand Down
Loading