Improved firebase configuration by adding security headers(#735) #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
changed the title
ymaheshwari1
approved these changes
Oct 20, 2024
ymaheshwari1
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks for the contribution @abhishekojha06
Please check the comments below.
| @@ -25,7 +25,25 @@ | |||
| "rewrites": [ { | |||
| "source": "**", | |||
| "destination": "/index.html" | |||
| }] | |||
| } ], | |||
| "headers": [ { | |||
There was a problem hiding this comment.
Add the same entry in the other two objects as well (prod and uat).
Also please update the formatting and indentation changes to follow this files pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#735 #104
this code works for deploying and hosting SPAs built with
frontend frameworks on Firebase Hosting, while handling
multiple environments and including essential security headers in development.