Add RingFilter and RingElementFilter to more rings #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
=======================================
Coverage 70.49% 70.50%
=======================================
Files 437 437
Lines 72099 72109 +10
=======================================
+ Hits 50827 50837 +10
Misses 21272 21272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mohamed-barakat
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
homalg-project/CAP_project#1628 requires all rings used for compilation and as
CommutativeRingOfLinearCategoryto have the attributesRingFilterandRingElementFilter. In particular, we have to set suitable filters for all homalg rings which we want to use asCommutativeRingOfLinearCategory. @mohamed-barakat Are you okay with this? This PR sets the required filters for all homalg rings appearing in the tests ofCAP_project.