Merge pull request #610 from zickgraf/master

Add RingFilter and RingElementFilter to more rings
homalg-project · Jul 9, 2024 · 3b863b0 · 3b863b0
2 parents a6731f3 + 1df4c5c
commit 3b863b0
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 4 deletions.
diff --git a/GaussForHomalg/PackageInfo.g b/GaussForHomalg/PackageInfo.g
@@ -11,7 +11,7 @@ SetPackageInfo( rec(
 
 PackageName := "GaussForHomalg",
 Subtitle := "Gauss functionality for the homalg project",
-Version := "2023.11-01",
+Version := "2024.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/GaussForHomalg/gap/GaussTools.gi b/GaussForHomalg/gap/GaussTools.gi
@@ -406,11 +406,18 @@ InstallGlobalFunction( HOMALG_RING_OF_INTEGERS_PRIME_POWER_HELPER,
             d := 1;
         fi;
         R := CreateHomalgRing( GF( c, d ) );
+
+        SetRingFilter( R, IsHomalgRing );
+        SetRingElementFilter( R, IsFFE );
+
         R!.NameOfPrimitiveElement := Concatenation( "Z", String( c ), "_", String( d ) );
         SetIsFieldForHomalg( R, true );
         SetRingProperties( R, c, d );
     else
         R := CreateHomalgRing( ZmodnZ( c ) );
+
+        SetRingFilter( R, IsHomalgRing );
+        SetRingElementFilter( R, IsZmodnZObj );
     fi;
     return R;
 end );
diff --git a/GradedRingForHomalg/PackageInfo.g b/GradedRingForHomalg/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "GradedRingForHomalg",
 Subtitle := "Endow Commutative Rings with an Abelian Grading",
-Version := "2023.08-01",
+Version := "2024.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/GradedRingForHomalg/gap/GradedRing.gi b/GradedRingForHomalg/gap/GradedRing.gi
@@ -779,6 +779,10 @@ InstallMethod( GradedRing,
 
     ## create the graded ring
     S := CreateHomalgRing( R, [ TheTypeHomalgGradedRing, ValueGlobal( "TheTypeHomalgMatrixOverGradedRing" ) ], GradedRingElement, RP );
+
+    SetRingFilter( S, IsHomalgGradedRingRep );
+    SetRingElementFilter( S, IsHomalgGradedRingElementRep );
+
     SetConstructorForHomalgMatrices( S,
       function( arg )
         local nargs, mat, R, l;

diff --git a/MatricesForHomalg/PackageInfo.g b/MatricesForHomalg/PackageInfo.g
@@ -11,7 +11,7 @@ SetPackageInfo( rec(
 
 PackageName := "MatricesForHomalg",
 Subtitle := "Matrices for the homalg project",
-Version := "2024.06-01",
+Version := "2024.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/MatricesForHomalg/gap/ResidueClassRing.gi b/MatricesForHomalg/gap/ResidueClassRing.gi
@@ -578,6 +578,9 @@ InstallMethod( \/, ## this operation is declared in the file HomalgRelations.gd
     ## create the residue class ring
     S := CreateHomalgRing( R, [ TheTypeHomalgResidueClassRing, TheTypeHomalgResidueClassMatrix ], HomalgResidueClassRingElement, RP );
 
+    SetRingFilter( S, IsHomalgResidueClassRingRep );
+    SetRingElementFilter( S, IsHomalgResidueClassRingElementRep );
+
     ## the constructor of matrices over residue class rings
     SetConstructorForHomalgMatrices( S,
             function( arg )

diff --git a/ToolsForHomalg/PackageInfo.g b/ToolsForHomalg/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "ToolsForHomalg",
 Subtitle := "Special methods and knowledge propagation tools",
-Version := "2023.11-01",
+Version := "2024.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/ToolsForHomalg/gap/ToolsForHomalg.gd b/ToolsForHomalg/gap/ToolsForHomalg.gd
@@ -105,6 +105,9 @@ DeclareAttribute( "RingElementFilter",
 SetRingFilter( Integers, IsIntegers );
 SetRingElementFilter( Integers, IsInt );
 
+SetRingFilter( Rationals, IsRationals );
+SetRingElementFilter( Rationals, IsRat );
+
 ####################################
 #
 # global functions and operations: