Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better C++ compatibility for branch fast_lio #23

Open
wants to merge 4 commits into
base: fast_lio
Choose a base branch
from
Open

Better C++ compatibility for branch fast_lio #23

wants to merge 4 commits into from

Commits on Mar 7, 2022

  1. Remove using namespace std from header

    @xaedes
    xaedes committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    4efe8ca View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Bug fixes: 

    add missing std:: namespace qualifiers.
remove unistd.h include which is only necessary for usleep but not available on all platforms.
implement usleep with c++ std libraries <thread> and <chrono>.
    @xaedes
    xaedes committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    78677a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Replace pthread by std::thread and std::mutex

    @xaedes
    xaedes committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    663869f View commit details
    Browse the repository at this point in the history

  2. Fix usage of try_lock result values. 

    pthread_mutex_trylock returns zero on success.
std::mutex::try_lock returns true on success.
The conditions checked for success of pthread_mutex_trylock, so they should now require result value of `true`.
    @xaedes
    xaedes committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    523fe56 View commit details
    Browse the repository at this point in the history