Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: small fixes to make unit tests pass for numpy<2 and pandas<2 #66

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

mbaak
Copy link
Contributor

@mbaak mbaak commented Dec 7, 2024

Fix of unit tests for numpy<2 and pandas<2. This is preparation work for migration to numpy>2 and pandas>2, together with popmon. (See draft PR from Mateusz.)

This is in preparation for migration to numpy>2 and pandas>2.

* FIX: python versions used in unit test, including python 3.12
* FIX: get rid of resource_filename for python 3.12
* FIX: remove obsolete distutils from package for python 3.12
* FIX: keep numpy and pandas below v2 for now
@mbaak mbaak requested a review from sbrugman December 7, 2024 13:48
@mbaak mbaak changed the title FIX: small fixes to make unit tests pass FIX: small fixes to make unit tests pass for numpy<2 and pandas<2 Dec 7, 2024
Copy link
Contributor

@mkopec87 mkopec87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests! :)

histogrammar/primitives/sparselybin.py Show resolved Hide resolved
histogrammar/resources.py Outdated Show resolved Hide resolved
- importlib only available since python 3.9
- turn off tests for deprecated python 3.8
histogrammar/resources.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mkopec87 mkopec87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbaak mbaak merged commit 50b76a5 into master Dec 9, 2024
4 checks passed
@mbaak mbaak deleted the fix_unit_tests branch December 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants