-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Numpy >= 2.0.0 and Pandas >= 2.0.0 #65
Support Numpy >= 2.0.0 and Pandas >= 2.0.0 #65
Conversation
mkopec87
commented
Dec 6, 2024
•
edited
Loading
edited
- Support numpy >= 2.0.0 (np.string_ -> np.bytes_).
- Fix test utility corner case error (test_numpy.twosigfigs function).
- Fix typo in build pipeline Python versions config list.
- aaand other stuff I'm discovering along the way ...
I struggle with 4 tests failing already on master (using numpy 1.26.4 and pandas 1.5.3): FAILED tests/test_numpy.py::TestNumpy::testSparselyBin - AssertionError: I've tried debugging one of those and it seems there is a difference between py and np versions in the bin "0":
hnpj has "0": 481.0, while hpyj has "0" : 383.0. Maybe someone from the project could help with those? |
Hi Mateusz, I made this PR that fixes the histogrammar unit tests for numpy<2.0.0 and pandas<2.0.0: For your PR, once this one is merged can you please rebase? Once your PR is merged in I will switch to pyproject.toml, then release the new patch version, and then switch to upgrading popmon. Btw, thanks for the work you already put in, I appreciate it. |
Thanks @mbaak ! Shall I include version bump / changelog / README updates in my PR or this will be part of pyproject.toml/release version PR ? |
I thought of adding my (small) fixes to the changelog & README after your fixes are in, so for the new release. |
- Fix test_numpy.twosigfigs method corner-case
- Sort json keys for assertion error message
- Refactor tests with Numpy() and Pandas() context managers - Remove pd.util.testing.makeMixedDataFrame not available
- Drop pandas and numpy version constraints - Remove unused twosigfigs method in test_gpu.py - Add test output files from historgrammar/notebooks to .gitignore
b63ca26
to
d7a90c1
Compare
Still getting one error in the tests:
This test was not really tested in master because of error in Pandas() context manager. |
Hi Mateusz, thanks, good catch! |
Fixed the test as you suggested, ready for review :) |