-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Make serialize methods return hex-encoded strings, instead of bytes #1657
feat!: Make serialize methods return hex-encoded strings, instead of bytes #1657
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1657 +/- ##
==========================================
- Coverage 66.37% 66.37% -0.01%
==========================================
Files 119 124 +5
Lines 8717 8871 +154
Branches 1920 1979 +59
==========================================
+ Hits 5786 5888 +102
+ Misses 2806 2743 -63
- Partials 125 240 +115 ☔ View full report in Codecov by Sentry. |
ce3258c
to
07a868a
Compare
9774ab0
to
010a58b
Compare
010a58b
to
9d33d90
Compare
07a868a
to
a1ce8e0
Compare
9d33d90
to
6a1fff8
Compare
a1ce8e0
to
e2574df
Compare
6a1fff8
to
9cf6017
Compare
9cf6017
to
64e29f8
Compare
e2574df
to
9c7a31f
Compare
64e29f8
to
016113a
Compare
016113a
to
64956fe
Compare
9c7a31f
to
83fbd4a
Compare
64956fe
to
d5b022c
Compare
83fbd4a
to
01c4f58
Compare
d5b022c
to
9d97081
Compare
01c4f58
to
f9682a5
Compare
9d97081
to
7dfd402
Compare
7dfd402
to
4e8551b
Compare
f9682a5
to
c743bd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @janniks 👏
b3d3921
to
faae503
Compare
Make serialize methods return hex-encoded strings, instead of bytes
Reasoning: Most people shouldn't need to know what buffers/bytes are, they know hex from seeing strings around though. They expect txs, keys, etc. to be a hex string.
Also, renames
AssetInfo
toAsset
for less confusion. With more strongly typed strings.Closes #1655
Migration
New behavior